Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SimpliSafe locks #28672

Merged
merged 11 commits into from Nov 13, 2019
Merged

Add support for SimpliSafe locks #28672

merged 11 commits into from Nov 13, 2019

Conversation

@bachya
Copy link
Contributor

bachya commented Nov 9, 2019

Description:

This PR adds support for SimpliSafe locks.

Related issue (if applicable): N/A

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11159

Example entry for configuration.yaml (if applicable):

simplisafe:
  accounts:
    - username: !secret simplisafe_username
      password: !secret simplisafe_password

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
@bachya bachya self-assigned this Nov 9, 2019
@project-bot project-bot bot added this to Needs review in Dev Nov 9, 2019
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Nov 9, 2019
@bachya bachya force-pushed the bachya:ss-lock branch 3 times, most recently from 6aa2157 to ecbc575 Nov 9, 2019
bachya added 6 commits Nov 9, 2019
@bachya bachya force-pushed the bachya:ss-lock branch from ecbc575 to 2d413d8 Nov 9, 2019
@bachya bachya marked this pull request as ready for review Nov 9, 2019
@bachya bachya changed the title Add support for SimpliSafe locks WIP: Add support for SimpliSafe locks Nov 9, 2019
@MartinHjelmare MartinHjelmare moved this from By Code Owner to Incoming in Dev Nov 9, 2019
@bachya bachya changed the title WIP: Add support for SimpliSafe locks Add support for SimpliSafe locks Nov 11, 2019
@bachya bachya moved this from Incoming to By Code Owner in Dev Nov 11, 2019
@bachya bachya mentioned this pull request Nov 11, 2019
2 of 2 tasks complete
bachya added 2 commits Nov 11, 2019
@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Nov 13, 2019

Please make sure, when moving PRs manually in the project board, to not put the PR card last in a list with an automation card. That will disable the automation. The automation card must be last in the list.

Dev automation moved this from By Code Owner to Review in progress Nov 13, 2019
Dev automation moved this from Review in progress to Reviewer approved Nov 13, 2019
Copy link
Member

MartinHjelmare left a comment

Nice!

@MartinHjelmare MartinHjelmare merged commit 8789da3 into home-assistant:dev Nov 13, 2019
11 checks passed
11 checks passed
CI Build #20191113.35 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected.
Details
codecov/project 94.44% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 13, 2019
pull bot added a commit to KoHcoJlb/home-assistant that referenced this pull request Nov 13, 2019
* Start

* Lock init

* More stubbing

* Final pieces for PR

* Fixed incorrect property access

* Updaed .coveragerc

* Ensure we can handle unknown states

* Account for lock's offline property

* Account for device online

* Unload components concurrently

* Handle unknown states more gracefully
@bachya bachya deleted the bachya:ss-lock branch Nov 13, 2019
@lock lock bot locked and limited conversation to collaborators Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.