Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google_assistant humidity sensors #28695

Merged
merged 1 commit into from Nov 26, 2019

Conversation

@Shulyaka
Copy link
Contributor

Shulyaka commented Nov 11, 2019

Description:

Expose humidity sensors to Google Assistant

Related issue (if applicable): N/A

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11155

Example entry for configuration.yaml (if applicable):

No configuration changes

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 11, 2019

Hey there @home-assistant/cloud, mind taking a look at this pull request as its been labeled with a integration (google_assistant) you are listed as a codeowner for? Thanks!

@Shulyaka Shulyaka mentioned this pull request Nov 11, 2019
2 of 2 tasks complete
@Shulyaka Shulyaka marked this pull request as ready for review Nov 11, 2019
@MartinHjelmare MartinHjelmare changed the title google_assistant: support for humidity sensors Add google_assistant humidity sensors Nov 11, 2019
@Shulyaka Shulyaka force-pushed the Shulyaka:google_assistant_sensor_only branch from d8693e4 to ae345cc Nov 12, 2019
@Shulyaka Shulyaka force-pushed the Shulyaka:google_assistant_sensor_only branch from ae345cc to 49d9663 Nov 12, 2019
Dev automation moved this from Needs review to Reviewer approved Nov 26, 2019
Copy link
Member

balloob left a comment

Nice!

@balloob balloob merged commit 1f72de1 into home-assistant:dev Nov 26, 2019
11 checks passed
11 checks passed
CI Build #20191112.50 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.43%)
Details
codecov/project 94.44% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 26, 2019
@lock lock bot locked and limited conversation to collaborators Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.