Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify getting alias from tplink smartplug.context #28696

Merged
merged 2 commits into from Nov 26, 2019

Conversation

@basnijholt
Copy link
Contributor

basnijholt commented Nov 11, 2019

Description:

I simplified getting the alias when smartplug.context is not None.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 11, 2019

Hey there @rytilahti, mind taking a look at this pull request as its been labeled with a integration (tplink) you are listed as a codeowner for? Thanks!

@MartinHjelmare MartinHjelmare changed the title tplink: simplify getting alias from smartplug.context Simplify getting alias from tplink smartplug.context Nov 11, 2019
@cgtobi
cgtobi approved these changes Nov 20, 2019
Copy link
Collaborator

cgtobi left a comment

LGTM

Dev automation moved this from Needs review to Reviewer approved Nov 20, 2019
@balloob balloob merged commit db425f5 into home-assistant:dev Nov 26, 2019
11 checks passed
11 checks passed
CI Build #20191115.25 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 3ce8502...816118b
Details
codecov/project 94.43% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 26, 2019
@lock lock bot locked and limited conversation to collaborators Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
6 participants
You can’t perform that action at this time.