Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config entry and device support to Demo #28702

Merged
merged 7 commits into from Nov 13, 2019
Merged

Add config entry and device support to Demo #28702

merged 7 commits into from Nov 13, 2019

Conversation

@bramkragten
Copy link
Member

bramkragten commented Nov 11, 2019

Description:

Adds device support to the demo platform so testing the frontend in a dev environment gets easier.

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@bramkragten bramkragten requested a review from home-assistant/core as a code owner Nov 11, 2019
@project-bot project-bot bot added this to Needs review in Dev Nov 11, 2019
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 11, 2019

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (demo) you are listed as a codeowner for? Thanks!

bramkragten added 2 commits Nov 11, 2019
Copy link
Member

MartinHjelmare left a comment

Take care not to mix sync api inside async context.

homeassistant/components/demo/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/demo/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/demo/air_quality.py Outdated Show resolved Hide resolved
homeassistant/components/demo/config_flow.py Outdated Show resolved Hide resolved
Dev automation moved this from Needs review to Review in progress Nov 12, 2019
Copy link
Member

MartinHjelmare left a comment

Looks good!

Just a question above.

Dev automation moved this from Review in progress to Reviewer approved Nov 12, 2019
bramkragten added 3 commits Nov 12, 2019
@bramkragten bramkragten merged commit 15e6278 into dev Nov 13, 2019
11 checks passed
11 checks passed
CI Build #20191112.44 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 96.93% of diff hit (target 94.42%)
Details
codecov/project 94.43% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 13, 2019
@delete-merged-branch delete-merged-branch bot deleted the demo-config-entry branch Nov 13, 2019
pull bot added a commit to KoHcoJlb/home-assistant that referenced this pull request Nov 13, 2019
* Add config entry and device support to Demo

* Some more devices

* Fix tests using demo

* Review comments

* Update config_flow.py

* Revert

* Disable pylint
@lock lock bot locked and limited conversation to collaborators Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.