Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ephem to 3.7.7.0 #28715

Merged
merged 1 commit into from Nov 14, 2019
Merged

Upgrade ephem to 3.7.7.0 #28715

merged 1 commit into from Nov 14, 2019

Conversation

@fabaff
Copy link
Member

fabaff commented Nov 12, 2019

Description:

  • Upgrade ephem to 3.7.7.0 (changelog)
  • Sort imports
  • Sort constants

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: season

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@cgtobi
cgtobi approved these changes Nov 14, 2019
Copy link
Collaborator

cgtobi left a comment

LGTM

Dev automation moved this from Needs review to Reviewer approved Nov 14, 2019
@cgtobi cgtobi merged commit c6d6bbf into dev Nov 14, 2019
12 checks passed
12 checks passed
CI Build #20191112.15 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.43%)
Details
codecov/project 94.44% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Nov 14, 2019
@delete-merged-branch delete-merged-branch bot deleted the ephem branch Nov 14, 2019
pull bot added a commit to KoHcoJlb/home-assistant that referenced this pull request Nov 14, 2019
@lock lock bot locked and limited conversation to collaborators Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.