Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sqlalchemy to 1.3.11 #28721

Merged
merged 1 commit into from Nov 16, 2019
Merged

Upgrade sqlalchemy to 1.3.11 #28721

merged 1 commit into from Nov 16, 2019

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Nov 12, 2019

Description:

Changelog: https://docs.sqlalchemy.org/en/13/changelog/changelog_13.html#change-1.3.11

Example entry for configuration.yaml (if applicable):

recoder:

sensor:
  - platform: sql
    queries:
      - name: Sun state
        query: "SELECT * FROM states WHERE entity_id = 'sun.sun' ORDER BY state_id DESC LIMIT 1;"
        column: 'state'

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.

@probot-home-assistant
Copy link

Hey there @dgomes, mind taking a look at this pull request as its been labeled with a integration (sql) you are listed as a codeowner for? Thanks!

Copy link
Contributor

@cgtobi cgtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Dev automation moved this from Needs review to Reviewer approved Nov 14, 2019
@fabaff fabaff merged commit d8ca2e9 into dev Nov 16, 2019
Dev automation moved this from Reviewer approved to Done Nov 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the upgrade-sqlalchemy branch November 16, 2019 08:56
pull bot pushed a commit to KoHcoJlb/home-assistant that referenced this pull request Nov 16, 2019
thomasgermain pushed a commit to thomasgermain/home-assistant that referenced this pull request Nov 16, 2019
@lock lock bot locked and limited conversation to collaborators Nov 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants