Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch Zeroconf exception #28728

Merged
merged 2 commits into from Nov 23, 2019
Merged

Catch Zeroconf exception #28728

merged 2 commits into from Nov 23, 2019

Conversation

@fabaff
Copy link
Member

fabaff commented Nov 12, 2019

Description:

If there is a running Home Assistant instance in the local network and the user start a second one then there is a traceback. It's more an issue which developers will encounter.

2019-11-12 10:09:16 ERROR (MainThread) [homeassistant.core] Error doing job: Future exception was never retrieved
Traceback (most recent call last):
  File "/usr/lib64/python3.7/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/home/fab/Documents/repos/ha/home-assistant/homeassistant/components/zeroconf/__init__.py", line 72, in zeroconf_hass_start
    zeroconf.register_service(info)
  File "/home/fab/Documents/repos/ha/home-assistant/lib64/python3.7/site-packages/zeroconf.py", line 1921, in register_service
    self.check_service(info, allow_name_change)
  File "/home/fab/Documents/repos/ha/home-assistant/lib64/python3.7/site-packages/zeroconf.py", line 2062, in check_service
    raise NonUniqueNameException
zeroconf.NonUniqueNameException

Example entry for configuration.yaml (if applicable):

default_config:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 12, 2019

Hey there @robbiet480, @Kane610, mind taking a look at this pull request as its been labeled with a integration (zeroconf) you are listed as a codeowner for? Thanks!

try:
zeroconf.register_service(info)
except NonUniqueNameException:
_LOGGER.warning(

This comment has been minimized.

Copy link
@balloob

balloob Nov 12, 2019

Member

This should be an error. As it means zeroconf won't run.

This comment has been minimized.

Copy link
@fabaff

fabaff Nov 17, 2019

Author Member

Done

zeroconf.register_service(info)
except NonUniqueNameException:
_LOGGER.warning(
"Other Home Assistant instance present in the local network"

This comment has been minimized.

Copy link
@balloob

balloob Nov 12, 2019

Member

It's not just another Home Assistant instance. It's another Home Assistant instance with the same name.

This comment has been minimized.

Copy link
@fabaff

fabaff Nov 17, 2019

Author Member

Rephrased

@cgtobi
cgtobi approved these changes Nov 20, 2019
Copy link
Collaborator

cgtobi left a comment

LGTM

Dev automation moved this from Needs review to Reviewer approved Nov 20, 2019
@fabaff fabaff merged commit f1d4a3c into dev Nov 23, 2019
11 checks passed
11 checks passed
CI Build #20191117.27 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 1208ab4...28cb53b
Details
codecov/project 94.45% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 23, 2019
@delete-merged-branch delete-merged-branch bot deleted the mdns-ha branch Nov 23, 2019
AndreBremer added a commit to AndreBremer/home-assistant that referenced this pull request Nov 24, 2019
* Catch Zeroconf exception

* Make it an error
@lock lock bot locked and limited conversation to collaborators Nov 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.