Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an early start sensor for tado heating zones #28732

Merged
merged 1 commit into from Nov 25, 2019

Conversation

@andersonshatch
Copy link
Contributor

andersonshatch commented Nov 12, 2019

Description:

Add a sensor indicating whether a tado heating zone is 'early start' heating to meet a desired temperature+schedule combination.
'Early start' is the term the tado UI uses for this pre-heat situation, so the term should be familiar to tado users.

Pull request with documentation for home-assistant.io (if applicable): N/A; other tado sensors are not explicitly documented, merely mentioned with

There is currently support for the following device types within Home Assistant:

  • ...
  • Sensor - for some additional information of the zones.

Example entry for configuration.yaml (if applicable):

tado:
  username: !secret tado_username
  password: !secret tado_password

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
Dev automation moved this from Needs review to Reviewer approved Nov 24, 2019
@michaelarnauts michaelarnauts merged commit 8fade79 into home-assistant:dev Nov 25, 2019
12 checks passed
12 checks passed
CI Build #20191112.61 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing a1f2b6d...93fbb9f
Details
codecov/project 94.43% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Nov 25, 2019
@lock lock bot locked and limited conversation to collaborators Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.