Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ombi password authentication option #28742

Merged
merged 2 commits into from Nov 16, 2019
Merged

Conversation

@larssont
Copy link
Contributor

larssont commented Nov 13, 2019

Description:

Adds the option to authenticate with a user password instead of an API key. Either a password or an API key must be supplied to successfully authenticate, if both are supplied the API key takes precedence.

Related issue (if applicable): fixes #28274

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11169

Example entry for configuration.yaml (if applicable):

ombi:
  host: 192.168.1.120
  username: MyUsername
  password: MyPassword123

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
@project-bot project-bot bot added this to Needs review in Dev Nov 13, 2019
@larssont larssont mentioned this pull request Nov 13, 2019
2 of 2 tasks complete
@larssont larssont marked this pull request as ready for review Nov 13, 2019
@MartinHjelmare MartinHjelmare changed the title Add password authentication option Add ombi password authentication option Nov 13, 2019
homeassistant/components/ombi/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/ombi/__init__.py Outdated Show resolved Hide resolved
Dev automation moved this from Needs review to Review in progress Nov 13, 2019
Copy link
Member

MartinHjelmare left a comment

Thanks!

Dev automation moved this from Review in progress to Reviewer approved Nov 14, 2019
@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Nov 14, 2019

Can be merged when build passes.

@fabaff fabaff merged commit 8a28d5f into home-assistant:dev Nov 16, 2019
11 checks passed
11 checks passed
CI Build #20191114.6 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected.
Details
codecov/project 94.44% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 16, 2019
pull bot added a commit to KoHcoJlb/home-assistant that referenced this pull request Nov 16, 2019
* Add password authentication option

* Add vol.Exclusive for auth config params
KJonline added a commit to KJonline/home-assistant that referenced this pull request Nov 16, 2019
* dev: (200 commits)
  Truncate sensor state values (home-assistant#28788)
  Fix broken postnl sensor (home-assistant#28794)
  Move imports in braviatv component (home-assistant#27855)
  Add ombi password authentication option (home-assistant#28742)
  Lint exclusions (home-assistant#28655)
  Upgrade pylint, tweak config (home-assistant#28798)
  Bump pyHik library to 0.2.5 for id, tamper fixes (home-assistant#28807)
  Upgrade sqlalchemy to 1.3.11 (home-assistant#28721)
  Fix Repetier integration entity indexing (home-assistant#28766)
  Updated frontend to 20191115.0 (home-assistant#28797)
  [ci skip] Translation update
  Add support for Hisense AEH-W4A1 wifi module (AC remote control) (home-assistant#28641)
  Fix changing venstar operation_mode (home-assistant#28754)
  Fix Swisscom empty response received (home-assistant#28782)
  Fix HomematicIP Cloud Alarm Control Panel support for basic mode (home-assistant#28778)
  Change keys for Samsung TV next and prev track command (home-assistant#28213)
  Change unique id for SAJ sensor based on device SN (home-assistant#28663)
  bump home mitemp_bt to 0.0.3. It has an important bugfix for reading … (home-assistant#28765)
  Convert Tesla to Async (home-assistant#28748)
  Bump pytest to 5.2.3 (home-assistant#28785)
  ...

# Conflicts:
#	homeassistant/generated/config_flows.py
#	script/gen_requirements_all.py
thomasgermain added a commit to thomasgermain/home-assistant that referenced this pull request Nov 16, 2019
* Add password authentication option

* Add vol.Exclusive for auth config params
@lock lock bot locked and limited conversation to collaborators Nov 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.