Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add small speed improvement when unloading Ambient PWS #28756

Merged
merged 1 commit into from Nov 13, 2019

Conversation

@bachya
Copy link
Contributor

bachya commented Nov 13, 2019

Description:

This PR adds some small speed improvements to ambient_pws by removing components concurrently when unloading the integration.

Related issue (if applicable): N/A

Pull request with documentation for home-assistant.io (if applicable): N/A

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
@bachya bachya self-assigned this Nov 13, 2019
@project-bot project-bot bot added this to Needs review in Dev Nov 13, 2019
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Nov 13, 2019
@bachya bachya merged commit c27b94c into home-assistant:dev Nov 13, 2019
12 checks passed
12 checks passed
CI Build #20191113.42 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 8789da3...6904064
Details
codecov/project 94.43% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from By Code Owner to Done Nov 13, 2019
@bachya bachya deleted the bachya:ambient-unload branch Nov 13, 2019
pull bot added a commit to KoHcoJlb/home-assistant that referenced this pull request Nov 13, 2019
@lock lock bot locked and limited conversation to collaborators Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
2 participants
You can’t perform that action at this time.