Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Resolve hosts for fritzbox_callmonitor #28761
If the configuration supplied "host" is not an IP address, try resolving it
I had written a hostname as "host" in my configuration.yaml for the fritzbox_callmonitor platform, and was getting warnings "fritzbox_callmonitor is taking longer than 10 seconds to initialize", and also could not find the phonebook with id 0.
Finally I found out, that I have to pass an IP address, and not a hostname in the host parameter. I personally find it nicer if both can be accepted, so I created this patch that checks whether host is an IP address, and if it isn't, tries to resolve it as a hostname.
Related issue (if applicable): I haven't created (or found) an issue for that; I can create one if required. Might be related to #21143.
Example entry for
I also thought about that, and checked a little more:
I would agree, that this is a corner case, but feels wrong to me. If you really want me to change it, I can do it of course; I just see my proposal as more robust.