Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for including plus sign in the volume for the squeezbox_call_method service #28763

Merged

Conversation

@springstan
Copy link
Member

springstan commented Nov 14, 2019

Breaking Change:

None

Description:

  • SQUEEZEBOX_CALL_METHOD cannot handle a volume level with a plus sign
  • this plus sign is encoded by urllib.parse.quote() to %2B
    -> added the plus sign to safe characters which are not encoded

Related issue (if applicable): fixes #28497

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Example for calling SQUEEZEBOX_CALL_METHOD:

{
  "entity_id": "media_player.squeezebox_radio",
  "command": "mixer",
  "parameters": ["volume", "+20"]
}

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Nov 14, 2019
Dev automation moved this from Needs review to Reviewer approved Nov 14, 2019
@balloob balloob merged commit ea0bae2 into home-assistant:dev Nov 14, 2019
12 checks passed
12 checks passed
CI Build #20191114.4 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 3f2c344...c17f804
Details
codecov/project 94.44% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Nov 14, 2019
pull bot added a commit to KoHcoJlb/home-assistant that referenced this pull request Nov 14, 2019
@lock lock bot locked and limited conversation to collaborators Nov 15, 2019
@springstan springstan deleted the springstan:FixSqueezeboxCallMethodPlusSignVolume branch Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.