Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump home mitemp_bt to 0.0.3. It has an important bugfix for reading … #28765

Merged
merged 2 commits into from Nov 15, 2019

Conversation

@herrlado
Copy link
Contributor

herrlado commented Nov 14, 2019

…temperatures under 10 grade

Breaking Change:

Description:

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
…temperatures under 10 grade
@homeassistant

This comment has been minimized.

Copy link
Contributor

homeassistant commented Nov 14, 2019

Hi @herrlado,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Dev automation moved this from Needs review to Reviewer approved Nov 15, 2019
@fabaff
fabaff approved these changes Nov 15, 2019
@fabaff fabaff merged commit bc14e93 into home-assistant:dev Nov 15, 2019
11 checks passed
11 checks passed
CI Build #20191114.9 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 3f2c344...a76d9a7
Details
codecov/project 94.44% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 15, 2019
pull bot added a commit to KoHcoJlb/home-assistant that referenced this pull request Nov 15, 2019
home-assistant#28765)

* bump home mitemp_bt to 0.0.3. It has an important bugfix for reading temperatures under 10 grade

* adjust the version number for mitemp_bt up to 0.0.3
@lock lock bot locked and limited conversation to collaborators Nov 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.