Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device trigger support for aqara 86sw2 switches to Deconz #28767

Merged
merged 3 commits into from Nov 14, 2019

Conversation

@bramkragten
Copy link
Member

bramkragten commented Nov 14, 2019

Adds device trigger for Aqara Wireless Light Control (aqara 86sw2) switches

@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 14, 2019

Hey there @Kane610, mind taking a look at this pull request as its been labeled with a integration (deconz) you are listed as a codeowner for? Thanks!

Copy link
Member

Kane610 left a comment

Looks good

@@ -209,6 +209,13 @@
(CONF_DOUBLE_PRESS, CONF_BOTH_BUTTONS): 3004,
}

AQARA_DOUBLE_WALL_SWITCH_86SW2_MODEL = "lumi.sensor_86sw2"
AQARA_DOUBLE_WALL_SWITCH_86SW2 = {

This comment has been minimized.

Copy link
@Kane610

Kane610 Nov 14, 2019

Member

Could we change 86sw2 to the model written on the backside of the device. Now with multiple similar devices I think it is important with clear bookkeeping

This comment has been minimized.

Copy link
@bramkragten

bramkragten Nov 14, 2019

Author Member

My Chinese is not so good... 😅

This comment has been minimized.

Copy link
@bramkragten

bramkragten Nov 14, 2019

Author Member

Google translate and google give me WXKG02LM?

Dev automation moved this from Needs review to Reviewer approved Nov 14, 2019
@Kane610

This comment has been minimized.

Copy link
Member

Kane610 commented Nov 14, 2019

Awesome 🎉

@Kane610 Kane610 merged commit b2870b6 into dev Nov 14, 2019
11 checks passed
11 checks passed
CI Build #20191114.20 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.43%)
Details
codecov/project 94.43% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 14, 2019
@delete-merged-branch delete-merged-branch bot deleted the deconz-device-trigger-aqara-double-switch branch Nov 14, 2019
pull bot added a commit to KoHcoJlb/home-assistant that referenced this pull request Nov 14, 2019
home-assistant#28767)

* Add device trigger support for aqara 86sw2 switched to Deconz

* Update device_trigger.py

* Update naming
@lock lock bot locked and limited conversation to collaborators Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.