Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Esphome climate features #28786

Merged
merged 6 commits into from Nov 17, 2019
Merged

Conversation

@glmnet
Copy link
Contributor

glmnet commented Nov 15, 2019

Description:

Adds ESPHome climate devices:

  • mode FAN_ONLY and DRY
  • Fan modes
  • Swing modes

Related issue (if applicable): fixes #esphome/feature-requests#333

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@glmnet glmnet requested a review from OttoWinter as a code owner Nov 15, 2019
@homeassistant

This comment has been minimized.

Copy link
Contributor

homeassistant commented Nov 15, 2019

Hi @glmnet,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 15, 2019

Hey there @OttoWinter, mind taking a look at this pull request as its been labeled with a integration (esphome) you are listed as a codeowner for? Thanks!

@glmnet glmnet mentioned this pull request Nov 15, 2019
2 of 5 tasks complete
@homeassistant homeassistant added cla-signed and removed cla-needed labels Nov 15, 2019
Dev automation moved this from Needs review to Reviewer approved Nov 15, 2019
Copy link
Member

OttoWinter left a comment

This side lgtm +1

Will push an update to aioesphomeapi later and then we can merge this.

@OttoWinter

This comment has been minimized.

Copy link
Member

OttoWinter commented Nov 16, 2019

Ok, I just published aioesphomeapi v2.6.0 with the changes from esphome/aioesphomeapi#4

When you update the aioesphomeapi version in this PR to 2.6.0 (and run script/gen_requirements_all) it's good to merge 🎉

glmnet added 6 commits Sep 26, 2019
@glmnet glmnet force-pushed the glmnet:esphome-climate-features branch from db5f20a to 1ec4754 Nov 16, 2019
@OttoWinter OttoWinter merged commit 0c48b8e into home-assistant:dev Nov 17, 2019
11 checks passed
11 checks passed
CI Build #20191116.27 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing d6e99db...1ec4754
Details
codecov/project 94.44% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 17, 2019
pull bot added a commit to KoHcoJlb/home-assistant that referenced this pull request Nov 17, 2019
* add esphome climate fan

* adds back compatibility support

* fixes, add swing mode

* revert client config

* sort import

* rebase
@lock lock bot locked and limited conversation to collaborators Nov 18, 2019
@glmnet glmnet deleted the glmnet:esphome-climate-features branch Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.