Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate Environment Canada sensor state values #28788

Merged
merged 1 commit into from Nov 16, 2019

Conversation

@michaeldavie
Copy link
Contributor

michaeldavie commented Nov 15, 2019

Description:

Ensures that state values do not exceed 255 characters

Related issue (if applicable): fixes issue raised at https://community.home-assistant.io/t/support-for-environment-canada-platforms/126241/109

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
@project-bot project-bot bot added this to Needs review in Dev Nov 15, 2019
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Nov 15, 2019
@MartinHjelmare MartinHjelmare changed the title Environment Canada - Truncate sensor state values Truncate Environment Canada sensor state values Nov 15, 2019
@fabaff
fabaff approved these changes Nov 16, 2019
Copy link
Member

fabaff left a comment

Looks good to me.

Dev automation moved this from By Code Owner to Reviewer approved Nov 16, 2019
@fabaff fabaff merged commit d736c5f into home-assistant:dev Nov 16, 2019
12 checks passed
12 checks passed
CI Build #20191115.3 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing b2870b6...339240f
Details
codecov/project 94.43% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Nov 16, 2019
pull bot added a commit to KoHcoJlb/home-assistant that referenced this pull request Nov 16, 2019
KJonline added a commit to KJonline/home-assistant that referenced this pull request Nov 16, 2019
* dev: (200 commits)
  Truncate sensor state values (home-assistant#28788)
  Fix broken postnl sensor (home-assistant#28794)
  Move imports in braviatv component (home-assistant#27855)
  Add ombi password authentication option (home-assistant#28742)
  Lint exclusions (home-assistant#28655)
  Upgrade pylint, tweak config (home-assistant#28798)
  Bump pyHik library to 0.2.5 for id, tamper fixes (home-assistant#28807)
  Upgrade sqlalchemy to 1.3.11 (home-assistant#28721)
  Fix Repetier integration entity indexing (home-assistant#28766)
  Updated frontend to 20191115.0 (home-assistant#28797)
  [ci skip] Translation update
  Add support for Hisense AEH-W4A1 wifi module (AC remote control) (home-assistant#28641)
  Fix changing venstar operation_mode (home-assistant#28754)
  Fix Swisscom empty response received (home-assistant#28782)
  Fix HomematicIP Cloud Alarm Control Panel support for basic mode (home-assistant#28778)
  Change keys for Samsung TV next and prev track command (home-assistant#28213)
  Change unique id for SAJ sensor based on device SN (home-assistant#28663)
  bump home mitemp_bt to 0.0.3. It has an important bugfix for reading … (home-assistant#28765)
  Convert Tesla to Async (home-assistant#28748)
  Bump pytest to 5.2.3 (home-assistant#28785)
  ...

# Conflicts:
#	homeassistant/generated/config_flows.py
#	script/gen_requirements_all.py
thomasgermain added a commit to thomasgermain/home-assistant that referenced this pull request Nov 16, 2019
@lock lock bot locked and limited conversation to collaborators Nov 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.