Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add broadcast_address for wake-on-lan #28793

Merged
merged 1 commit into from Nov 17, 2019

Conversation

@uSpike
Copy link
Contributor

uSpike commented Nov 15, 2019

Breaking Change:

NA

Description:

Adds broadcast_address as a configuration key to specify the address to which the wake-on-lan packet should be sent.

Related issue (if applicable): fixes #28792
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11187

Example entry for configuration.yaml (if applicable):

media_player:
  - platform: panasonic_viera
    host: 10.52.110.10
    broadcast_address: 10.52.110.255
    mac: <redacted>
    name: "Basement TV"

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@fabaff
fabaff approved these changes Nov 17, 2019
Copy link
Member

fabaff left a comment

Looks good to me.

Dev automation moved this from Needs review to Reviewer approved Nov 17, 2019
@fabaff fabaff merged commit f25a3cb into home-assistant:dev Nov 17, 2019
12 checks passed
12 checks passed
CI Build #20191115.26 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 3500084...8300b65
Details
codecov/project 94.43% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Nov 17, 2019
pull bot added a commit to KoHcoJlb/home-assistant that referenced this pull request Nov 17, 2019
@lock lock bot locked and limited conversation to collaborators Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.