Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade shodan to 1.19.1 #28809

Merged
merged 1 commit into from Nov 16, 2019
Merged

Upgrade shodan to 1.19.1 #28809

merged 1 commit into from Nov 16, 2019

Conversation

@fabaff
Copy link
Member

fabaff commented Nov 16, 2019

Description:

Changelog: https://github.com/achillean/shodan-python/blob/master/CHANGELOG.md#changelog

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: shodan
    api_key: !secret shodan_api
    query: 'home-assistant'

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
@project-bot project-bot bot added this to Needs review in Dev Nov 16, 2019
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Nov 16, 2019
@fabaff fabaff merged commit fbe3d8d into dev Nov 16, 2019
12 checks passed
12 checks passed
CI Build #20191116.7 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 2aee366...3fa22d7
Details
codecov/project 94.43% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from By Code Owner to Done Nov 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the upgrade-shodan branch Nov 16, 2019
pull bot added a commit to KoHcoJlb/home-assistant that referenced this pull request Nov 16, 2019
thomasgermain added a commit to thomasgermain/home-assistant that referenced this pull request Nov 16, 2019
@lock lock bot locked and limited conversation to collaborators Nov 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
2 participants
You can’t perform that action at this time.