Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump androidtv to 0.0.34 #28816

merged 5 commits into from Nov 17, 2019


Copy link

JeffLIrion commented Nov 16, 2019


Bump androidtv to 0.0.34.


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
@project-bot project-bot bot added this to Needs review in Dev Nov 16, 2019
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Nov 16, 2019
@@ -319,7 +323,7 @@ def __init__(self, aftv, name, apps, turn_on_command, turn_off_command):

# Property attributes
self._adb_response = None
self._available = self.aftv.available
self._available = True

This comment has been minimized.

Copy link

JeffLIrion Nov 16, 2019

Author Contributor

This check was unnecessary because we already check it in the setup_platform function, and if it's not available then we don't create the MediaPlayerDevice instance:

fabaff approved these changes Nov 17, 2019
Dev automation moved this from By Code Owner to Reviewer approved Nov 17, 2019
@fabaff fabaff merged commit c7f684d into home-assistant:dev Nov 17, 2019
12 checks passed
12 checks passed
CI Build #20191116.24 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.44%)
codecov/project 94.44% (target 90%)
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Nov 17, 2019
pull bot added a commit to KoHcoJlb/home-assistant that referenced this pull request Nov 17, 2019
* Bump androidtv to 0.0.33; add pure-python-adb requirement

* python -m script.gen_requirements_all

* Avoid redundant 'available' check

* Bump androidtv to 0.0.34

* Update docstrings for the decorator functions
@lock lock bot locked and limited conversation to collaborators Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.