Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP view to conversation to handle intents via JSON POST #28818

Merged
merged 1 commit into from Nov 19, 2019

Conversation

@synesthesiam
Copy link
Contributor

synesthesiam commented Nov 16, 2019

Description:

Adds an HTTP view to conversation that accepts and handles intents via JSON. A POST to api/conversation/handle with { "name": "HassTurnOn", "data": { "name": "Kitchen light" } } will turn on the kitchen light. name is required while data is optional.

This addition is for external assistants, such as Rhasspy, to use Home Assistant as an intent handler only (when intent recognition is done externally).

Example entry for configuration.yaml (if applicable):

conversation:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@synesthesiam synesthesiam requested a review from home-assistant/core as a code owner Nov 16, 2019
@homeassistant

This comment has been minimized.

Copy link
Contributor

homeassistant commented Nov 16, 2019

Hi @synesthesiam,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 16, 2019

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (conversation) you are listed as a codeowner for? Thanks!

@homeassistant homeassistant added cla-signed and removed cla-needed labels Nov 16, 2019
Dev automation moved this from Needs review to Reviewer approved Nov 19, 2019
@balloob balloob merged commit c2161b1 into home-assistant:dev Nov 19, 2019
12 checks passed
12 checks passed
CI Build #20191116.30 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot All contributors have signed the CLA
codecov/patch Coverage not affected when comparing d6e99db...113025d
Details
codecov/project 94.45% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Nov 19, 2019
@lock lock bot locked and limited conversation to collaborators Nov 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.