Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add broadcast address for WOL and samsungtv #28819

Merged
merged 4 commits into from Nov 17, 2019

Conversation

@JayNewstrom
Copy link
Contributor

JayNewstrom commented Nov 16, 2019

Description:

Related issue (if applicable): fixes #28789

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11201

Example entry for configuration.yaml (if applicable):

media_player:
  - platform: samsungtv
    host: 192.168.5.36
    broadcast_address: 192.168.5.255
    port: 8001
    mac: <redacted>

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@JayNewstrom JayNewstrom requested a review from home-assistant/core as a code owner Nov 16, 2019
@homeassistant

This comment has been minimized.

Copy link
Contributor

homeassistant commented Nov 16, 2019

Hi @JayNewstrom,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 16, 2019

Hey there @escoand, mind taking a look at this pull request as its been labeled with a integration (samsungtv) you are listed as a codeowner for? Thanks!

@homeassistant homeassistant added cla-signed and removed cla-needed labels Nov 16, 2019
@JayNewstrom JayNewstrom mentioned this pull request Nov 16, 2019
2 of 2 tasks complete
JayNewstrom added 3 commits Nov 16, 2019
@JayNewstrom

This comment has been minimized.

Copy link
Contributor Author

JayNewstrom commented Nov 16, 2019

Ok, I think this is ready to review now @escoand. I saw there were some tests for state for other aspects. I added a new test for the new functionality. If you want me to add a test for state as well, let me know.

@fabaff
fabaff approved these changes Nov 17, 2019
Copy link
Member

fabaff left a comment

Looks good to me.

Dev automation moved this from Needs review to Reviewer approved Nov 17, 2019
@fabaff fabaff merged commit cb63a9d into home-assistant:dev Nov 17, 2019
11 checks passed
11 checks passed
CI Build #20191116.42 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.44%)
Details
codecov/project 94.44% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 17, 2019
Copy link
Contributor

escoand left a comment

LGTM

pull bot added a commit to KoHcoJlb/home-assistant that referenced this pull request Nov 17, 2019
* Add broadcast address for WOL and samsungtv

* Fix style

* Fix tests, and add new test for new functionality

* Fix code style
@JayNewstrom JayNewstrom deleted the JayNewstrom:broadcast-wol-samsungtv branch Nov 17, 2019
@lock lock bot locked and limited conversation to collaborators Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.