Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZHA service to issue group commands #28823

Merged
merged 2 commits into from Nov 20, 2019
Merged

Conversation

@abmantis
Copy link
Contributor

abmantis commented Nov 17, 2019

Description:

Adds the issue_zigbee_group_command to zha, allowing issuing cluster commands to zigbee groups.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 17, 2019

Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as its been labeled with a integration (zha) you are listed as a codeowner for? Thanks!

@MartinHjelmare MartinHjelmare changed the title add service to ZHA to issue group commands Add ZHA service to issue group commands Nov 17, 2019
Copy link
Contributor

dmulcahey left a comment

@Adminiuga this looks good to me... you're the groups guy though :D is this what you would expect?

@Adminiuga

This comment has been minimized.

Copy link
Contributor

Adminiuga commented Nov 19, 2019

I need to find some time to review/test this more carefully. Hoping today or tomorrow, it's being quite busy lately. Please hold off for now.
I'm gonna change title to WIP, ok?

@Adminiuga Adminiuga changed the title Add ZHA service to issue group commands WIP Add ZHA service to issue group commands Nov 19, 2019
@Adminiuga Adminiuga changed the title WIP Add ZHA service to issue group commands Add ZHA service to issue group commands Nov 20, 2019
Copy link
Contributor

Adminiuga left a comment

Looks good! I'm totally expecting the following PRs to follow:

  • allow cluster command attributes for zha.issue_zigbee_cluster_command service call
  • allow exclusive command or command_name specifying the command to be executed
Dev automation moved this from Needs review to Reviewer approved Nov 20, 2019
@Adminiuga Adminiuga merged commit e60ae77 into home-assistant:dev Nov 20, 2019
11 checks passed
11 checks passed
CI #20191119.38 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing ff1a02a...0858bfd
Details
codecov/project 94.46% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 20, 2019
@lock lock bot locked and limited conversation to collaborators Nov 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.