Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align naming #28830

merged 2 commits into from Nov 17, 2019

Align naming #28830

merged 2 commits into from Nov 17, 2019


Copy link

fabaff commented Nov 17, 2019

Breaking Change:

The configuration key mac_address: was renamed to mac: to be in sync with with the service.


  • Use mac: for the service and the platform
  • Use constant from

Pull request with documentation for (if applicable): home-assistant/

Example entry for configuration.yaml (if applicable):



  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Nov 17, 2019
@fabaff fabaff mentioned this pull request Nov 17, 2019
2 of 2 tasks complete
Dev automation moved this from Needs review to Reviewer approved Nov 17, 2019
frenck approved these changes Nov 17, 2019
Copy link

frenck left a comment


@fabaff fabaff merged commit 101ab5c into dev Nov 17, 2019
11 checks passed
11 checks passed
CI Build #20191117.14 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch No report found to compare against
codecov/project 94.44% (target 90%)
Dev automation moved this from Reviewer approved to Done Nov 17, 2019
@frenck frenck deleted the wol branch Nov 17, 2019
pull bot added a commit to KoHcoJlb/home-assistant that referenced this pull request Nov 17, 2019
* Align naming

* Update tests
@lock lock bot locked and limited conversation to collaborators Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.