Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow rest sensor list responses #28835

Merged
merged 7 commits into from Nov 26, 2019
Merged

Conversation

@gjbadros
Copy link
Contributor

gjbadros commented Nov 17, 2019

Description:

Now rest sensor supports a response which is a list where the first element of the list is a dictionary (instead of insisting that the response is actually a dictionary).

This seems to be a common case with some of the APIs where I'm using the rest sensor (e.g., returning an error code or a list of dictionaries).

Checklist:

  • [ x] The code change is tested and works locally.
  • [ x ] Local tests pass with tox. Your PR cannot be merged unless tests pass
  • [ x ] There is no commented out code in this PR.
  • [ x] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
gjbadros added 3 commits Aug 10, 2019
Syncing from hass master around 0.97.1
… be a list with 0th element being a dictionary
@project-bot project-bot bot added this to Needs review in Dev Nov 17, 2019
gjbadros added a commit to gjbadros/home-assistant.io that referenced this pull request Nov 17, 2019
@gjbadros gjbadros mentioned this pull request Nov 17, 2019
1 of 2 tasks complete
homeassistant/components/rest/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/rest/sensor.py Show resolved Hide resolved
Dev automation moved this from Needs review to Review in progress Nov 17, 2019
gjbadros added 4 commits Nov 17, 2019
…quences for log messages; I generally prefer explicit + rather than string juxtaposition for combining string literals, but sounds like that's not the standard
…he one with json_attrs.
@gjbadros gjbadros requested a review from fabaff Nov 23, 2019
@MartinHjelmare MartinHjelmare changed the title Better rest sensor allowing list responses since that's a common case Allow rest sensor list responses Nov 23, 2019
Dev automation moved this from Review in progress to Reviewer approved Nov 26, 2019
@fabaff
fabaff approved these changes Nov 26, 2019
@fabaff fabaff merged commit 5f1b0fb into home-assistant:dev Nov 26, 2019
11 checks passed
11 checks passed
CI #20191119.1 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.44%)
Details
codecov/project 94.45% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 26, 2019
frenck added a commit to home-assistant/home-assistant.io that referenced this pull request Nov 26, 2019
@lock lock bot locked and limited conversation to collaborators Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.