Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vivotek camera integration #28841

Merged
merged 1 commit into from Nov 18, 2019

Conversation

@HarlemSquirrel
Copy link
Contributor

HarlemSquirrel commented Nov 18, 2019

Description:

  • Add optional security_level config
  • Bump libpyvivotek to 0.3.1

Related issue (if applicable): fixes #27419

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11217

Example entry for configuration.yaml (if applicable):

camera:
  - platform: vivotek
    name: Front door camera
    ip_address: 192.168.1.2
    ssl: true
    username: !secret fd_camera_username
    password: !secret fd_camera_pwd
    security_level: admin
    verify_ssl: false
    framerate: 5
    stream_path: live2.sdp

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
- Add optional security_level config
- Bump libpyvivotek to 0.3.1
@cgtobi
cgtobi approved these changes Nov 18, 2019
Copy link
Collaborator

cgtobi left a comment

LGTM

@cgtobi cgtobi merged commit a4ae9a9 into home-assistant:dev Nov 18, 2019
12 checks passed
12 checks passed
CI Build #20191118.2 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 3d5b007...77a6b27
Details
codecov/project 94.45% (target 90%)
Details
docs-missing Documentation ok.
@lock lock bot locked and limited conversation to collaborators Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.