Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade duplicate YAML key log to warning #28851

Merged
merged 1 commit into from Nov 19, 2019
Merged

Downgrade duplicate YAML key log to warning #28851

merged 1 commit into from Nov 19, 2019

Conversation

@frenck
Copy link
Member

frenck commented Nov 18, 2019

Description:

In case of a duplicate YAML key, our configuration check will just pass. However, when actually using the configuration, Home Assistant will throw errors in the log. This is handled gracefully. Home Assistant will continue to work.

Hence, an ERROR level log message might suggest differently. (See raised issue #22525). This PR downgrades the log level to WARNING in case of a duplicate key.

Related issue (if applicable): fixes #22525

Pull request with documentation for home-assistant.io (if applicable): n/a

Example entry for configuration.yaml (if applicable): n/a

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
@frenck frenck added this to Needs review in Dev via automation Nov 18, 2019
Dev automation moved this from Needs review to Reviewer approved Nov 19, 2019
@balloob balloob merged commit 21157f9 into dev Nov 19, 2019
12 checks passed
12 checks passed
CI Build #20191118.22 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.44%)
Details
codecov/project 94.44% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Nov 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the frenck-2019-0264 branch Nov 19, 2019
@lock lock bot locked and limited conversation to collaborators Nov 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.