Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hvac_action to HomematicIP Cloud Climate #28859

Merged
merged 5 commits into from Nov 26, 2019

Conversation

@SukramJ
Copy link
Contributor

SukramJ commented Nov 18, 2019

Description:

Add hvac_action to HomematicIP Cloud Climate

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
):
return CURRENT_HVAC_HEAT

return None

This comment has been minimized.

Copy link
@balloob

balloob Nov 19, 2019

Member

Should this be CURRENT_HVAC_IDLE ?

This comment has been minimized.

Copy link
@SukramJ

SukramJ Nov 19, 2019

Author Contributor

I don't think so. The HeatingGroup could contain multiple sources for heating (floor, radiator) at the same time, but we only know that the radiator is currently active as an additional heat source. But we cannot say the HeatingGroup is idle when the radiator is off. We do not have the info if the floor heater is currently heating.
I hope that is understandable.

This comment has been minimized.

Copy link
@SukramJ

SukramJ Nov 25, 2019

Author Contributor

Sorry, i had to rebase and push -f.
I switched the implementation to be for radiators only. In this case HEAT and IDLE action are possible.

@MartinHjelmare MartinHjelmare added this to Needs review in Dev Nov 20, 2019
@frenck frenck moved this from Needs review to By Code Owner in Dev Nov 20, 2019
@SukramJ SukramJ closed this Nov 25, 2019
Dev automation moved this from By Code Owner to Cancelled Nov 25, 2019
@SukramJ SukramJ reopened this Nov 25, 2019
Dev automation moved this from Cancelled to Incoming Nov 25, 2019
SukramJ added 3 commits Nov 18, 2019
@SukramJ SukramJ force-pushed the SukramJ:HmIP-HVAC_Action branch from f4a4232 to 75b5cc4 Nov 25, 2019
@MartinHjelmare MartinHjelmare moved this from Incoming to Needs review in Dev Nov 26, 2019
Dev automation moved this from Needs review to Reviewer approved Nov 26, 2019
@balloob balloob merged commit c116328 into home-assistant:dev Nov 26, 2019
11 checks passed
11 checks passed
CI #20191126.55 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.47%)
Details
codecov/project 94.49% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 26, 2019
@SukramJ SukramJ deleted the SukramJ:HmIP-HVAC_Action branch Nov 26, 2019
@lock lock bot locked and limited conversation to collaborators Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.