Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move imports to top for alarmdecoder #28862

Merged
merged 1 commit into from Nov 19, 2019
Merged

Move imports to top for alarmdecoder #28862

merged 1 commit into from Nov 19, 2019

Conversation

@frenck
Copy link
Member

frenck commented Nov 18, 2019

Description:

Move imports for #27284

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
@frenck frenck changed the title Move import to top for alarmdecoder Move imports to top for alarmdecoder Nov 18, 2019
@frenck frenck mentioned this pull request Nov 18, 2019
517 of 518 tasks complete
@balloob balloob merged commit 2d4b038 into dev Nov 19, 2019
12 checks passed
12 checks passed
CI #20191118.40 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 61bb24c...37bb312
Details
codecov/project 94.45% (target 90%)
Details
docs-missing Documentation ok.
@delete-merged-branch delete-merged-branch bot deleted the frenck-2019-0268 branch Nov 19, 2019
@lock lock bot locked and limited conversation to collaborators Nov 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.