Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark entity abc #28869

Merged
merged 3 commits into from Nov 19, 2019
Merged

Mark entity abc #28869

merged 3 commits into from Nov 19, 2019

Conversation

@balloob
Copy link
Member

balloob commented Nov 18, 2019

Description:

Mark Entity class an ABC so we can add abstract methods.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
balloob added 2 commits Nov 18, 2019
@balloob balloob requested a review from home-assistant/core as a code owner Nov 18, 2019
@balloob

This comment has been minimized.

Copy link
Member Author

balloob commented Nov 19, 2019

By adding this to more integrations, we'll be able to find integrations that are not implementing the right methods.

@balloob balloob merged commit 94675ca into dev Nov 19, 2019
11 checks passed
11 checks passed
CI #20191119.19 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.45%)
Details
codecov/project 94.47% (target 90%)
Details
@delete-merged-branch delete-merged-branch bot deleted the mark-entity-abc branch Nov 19, 2019
@lock lock bot locked and limited conversation to collaborators Nov 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.