Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @rohankapoorcom to CODEOWNERS for speedtestdotnet and fastdotcom #28879

Merged
merged 1 commit into from Nov 19, 2019

Conversation

@rohankapoorcom
Copy link
Member

rohankapoorcom commented Nov 19, 2019

Description:

Add myself as the CODEOWNERS for fastdotcom and speedtestdotnet. I've done the majority of the work on these components (including the last rewrite) and plan on doing further work here. This includes swapping out the speedtestdotnet library implementation to use the new API released by Ookla.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
Copy link
Member

balloob left a comment

🎉

@balloob balloob merged commit cd8c281 into home-assistant:dev Nov 19, 2019
10 checks passed
10 checks passed
CI #20191119.22 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
docs-missing Documentation ok.
@rohankapoorcom rohankapoorcom deleted the rohankapoorcom:speedtest-codeowners branch Nov 19, 2019
@lock lock bot locked and limited conversation to collaborators Nov 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.