Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uptime and number of reboot for bbox sensor #28880

Merged
merged 3 commits into from Nov 26, 2019

Conversation

@Mryck
Copy link
Contributor

Mryck commented Nov 19, 2019

Description:

This modification add number of reboot and uptime of the bbox router. If the code is fine I will update the doc as soon as possible.

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: bbox
    monitored_variables:
      - down_max_bandwidth
      - up_max_bandwidth
      - current_down_bandwidth
      - current_up_bandwidth
      - uptime
      - number_of_reboots

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@@ -126,6 +128,12 @@ def update(self):
self._state = round(self.bbox_data.data["rx"]["bandwidth"] / 1000, 2)
elif self.type == "current_up_bandwidth":
self._state = round(self.bbox_data.data["tx"]["bandwidth"] / 1000, 2)
elif self.type == "uptime":
self._state = str(
timedelta(seconds=self.bbox_data.router_infos["device"]["uptime"])

This comment has been minimized.

Copy link
@frenck

frenck Nov 19, 2019

Member

We should not put relative times in the state machine since it will update a lot and just spams updates due to the time that is passing.

Please use a timestamp device class for this specific sensor as a device class and calculate/format the time to absolute UTC iso format.

Example from other integration that calculates this: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/wled/sensor.py#L121

This comment has been minimized.

Copy link
@Mryck

Mryck Nov 19, 2019

Author Contributor

I hope it's better this time, sorry for my lack of knowledge 😄

@frenck frenck added this to Needs review in Dev via automation Nov 19, 2019
@frenck

This comment has been minimized.

Copy link
Member

frenck commented Nov 19, 2019

LOL OK, well 2 confirms it I guess 🤷‍♂

Mryck added 2 commits Nov 19, 2019
@Mryck Mryck requested a review from frenck Nov 20, 2019
@MartinHjelmare MartinHjelmare moved this from Needs review to Review in progress in Dev Nov 20, 2019
@balloob balloob merged commit 72ccc83 into home-assistant:dev Nov 26, 2019
11 checks passed
11 checks passed
CI #20191119.33 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 21157f9...583ec75
Details
codecov/project 94.47% (target 90%)
Details
Dev automation moved this from Review in progress to Done Nov 26, 2019
@Mryck Mryck mentioned this pull request Nov 26, 2019
2 of 2 tasks complete
@lock lock bot locked and limited conversation to collaborators Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.