Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster command arguments for issue_zigbee_cluster_command service. #28885

Merged
merged 1 commit into from Nov 20, 2019

Conversation

@Adminiuga
Copy link
Contributor

Adminiuga commented Nov 20, 2019

Description:

Allow specification of cluster command arguments for zha.issue_zigbee_cluster_command service.
For example a move_to_level_with_on_off command on Level cluster of a light:

ieee: '7c:b0:3e:aa:00:ab:cd:ef'
endpoint_id: 3
cluster_id: 8
cluster_type: in
command: 0
command_type: server
args:
  - 254
  - 20

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 20, 2019

Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as its been labeled with a integration (zha) you are listed as a codeowner for? Thanks!

@Adminiuga Adminiuga added small-pr and removed small-pr labels Nov 20, 2019
@MartinHjelmare MartinHjelmare added this to Needs review in Dev Nov 20, 2019
Copy link
Contributor

dmulcahey left a comment

LGTM.

Dev automation moved this from Needs review to Reviewer approved Nov 20, 2019
@dmulcahey dmulcahey merged commit 4ba2bd2 into home-assistant:dev Nov 20, 2019
2 checks passed
2 checks passed
cla-bot Everyone involved has signed the CLA
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Nov 20, 2019
@lock lock bot locked and limited conversation to collaborators Nov 21, 2019
@Adminiuga Adminiuga deleted the Adminiuga:ac/zha-cluster-command branch Jan 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.