Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serial to caseta devices #28886

Merged
merged 6 commits into from Nov 26, 2019
Merged

Add serial to caseta devices #28886

merged 6 commits into from Nov 26, 2019

Conversation

@mdonoughe
Copy link
Contributor

mdonoughe commented Nov 20, 2019

Description:

This adds serial numbers to lutron_caseta devices and enables the entity registry.

This was previously entered as #14037 which could not be merged because pylutron_caseta had not released.

Related issue (if applicable): Incidentally, because this brings in the new release of pylutron_caseta it also partially addresses #22907. It does not add support for fans, but users will no longer lose functionality when a fan controller is introduced.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable): N/A

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@MartinHjelmare MartinHjelmare added this to Needs review in Dev Nov 20, 2019
@MartinHjelmare MartinHjelmare changed the title add model and serial to caseta devices Add model and serial to caseta devices Nov 20, 2019
@djj211 djj211 mentioned this pull request Nov 24, 2019
6 of 7 tasks complete
Dev automation moved this from Needs review to Reviewer approved Nov 26, 2019
Copy link
Member

balloob left a comment

Few small comments, ok to merge when addressed.

mdonoughe added 3 commits Nov 26, 2019
@mdonoughe mdonoughe changed the title Add model and serial to caseta devices Add serial to caseta devices Nov 26, 2019
@balloob balloob merged commit f8a3649 into home-assistant:dev Nov 26, 2019
6 of 9 checks passed
6 of 9 checks passed
CI #20191126.44 failed
Details
CI (Tests PyTest Python36) Tests PyTest Python36 failed
Details
CI (Tests PyTest Python37) Tests PyTest Python37 failed
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
cla-bot Everyone involved has signed the CLA
Dev automation moved this from Reviewer approved to Done Nov 26, 2019
@@ -0,0 +1,5 @@
{
"config": {
"title": "Lutron Caséta"

This comment has been minimized.

Copy link
@MartinHjelmare

MartinHjelmare Nov 26, 2019

Member

Where is this used?

This comment has been minimized.

Copy link
@mdonoughe

mdonoughe Nov 27, 2019

Author Contributor

This appears in the entity registry.

This comment has been minimized.

Copy link
@balloob

balloob Nov 27, 2019

Member

(in the UI)

This comment has been minimized.

Copy link
@MartinHjelmare

MartinHjelmare Nov 27, 2019

Member

Should we now always add this file if the entity registry is active for an integration?

This comment has been minimized.

Copy link
@balloob

balloob Nov 27, 2019

Member

It looks like that is a new requirement based on the recent changes. I would love for us to be add this translation key at the root instead of config, so we could split out translations into multiple files in the future.

I don't like translation of titles of integrations, but for built-in ones like Lights etc it's useful.

@lock lock bot locked and limited conversation to collaborators Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.