Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update services.yaml for cloudflare component #28888

merged 2 commits into from Nov 20, 2019


Copy link

raman325 commented Nov 20, 2019


Update services.yaml for cloudflare component. I found a single service call under the cloudflare domain with no inputs so this was a pretty simple update.

Related issue (if applicable): Helps with #27289


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@raman325 raman325 requested a review from ludeeus as a code owner Nov 20, 2019
@MartinHjelmare MartinHjelmare changed the title update services.yaml for cloudflare component Update services.yaml for cloudflare component Nov 20, 2019
@MartinHjelmare MartinHjelmare added this to Needs review in Dev Nov 20, 2019
cgtobi approved these changes Nov 20, 2019
Copy link

cgtobi left a comment


Dev automation moved this from Needs review to Reviewer approved Nov 20, 2019
@cgtobi cgtobi merged commit 288ae8b into home-assistant:dev Nov 20, 2019
11 checks passed
11 checks passed
CI #20191120.9 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing e60ae77...3ae7488
codecov/project 94.47% (target 90%)
Dev automation moved this from Reviewer approved to Done Nov 20, 2019
@lock lock bot locked and limited conversation to collaborators Nov 21, 2019
@raman325 raman325 deleted the raman325:cloudflare_service_yaml_update branch Nov 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.