Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device trigger support for Aqara WXKG11LM 2016 switch to Deconz #28946

Merged
merged 1 commit into from Nov 22, 2019

Conversation

@kurniawan77 kurniawan77 requested a review from Kane610 as a code owner Nov 22, 2019
@homeassistant

This comment has been minimized.

Copy link
Contributor

homeassistant commented Nov 22, 2019

Hi @kurniawan77,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 22, 2019

Hey there @Kane610, mind taking a look at this pull request as its been labeled with a integration (deconz) you are listed as a codeowner for? Thanks!

@homeassistant homeassistant added cla-signed and removed cla-needed labels Nov 22, 2019
@Kane610

This comment has been minimized.

Copy link
Member

Kane610 commented Nov 22, 2019

Thanks for submitting! No long press on this button?

@kurniawan77

This comment has been minimized.

Copy link
Contributor Author

kurniawan77 commented Nov 22, 2019

Thanks for submitting! No long press on this button?

Afaik not, this is the 2016 model. 2018 model does have this and if you look at the link i posted https://github.com/dresden-elektronik/deconz-rest-plugin/wiki/Xiaomi-WXKG11LM-2016 it doesn't

Dev automation moved this from Needs review to Reviewer approved Nov 22, 2019
@Kane610 Kane610 merged commit 9a23a1c into home-assistant:dev Nov 22, 2019
12 checks passed
12 checks passed
CI #20191122.6 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot All contributors have signed the CLA
codecov/patch 100% of diff hit (target 94.47%)
Details
codecov/project 94.47% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Nov 22, 2019
@lock lock bot locked and limited conversation to collaborators Nov 23, 2019
@kurniawan77 kurniawan77 deleted the kurniawan77:patch-1 branch Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.