Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make conversation and intent context aware #28965

Merged
merged 2 commits into from Nov 26, 2019
Merged

Make conversation and intent context aware #28965

merged 2 commits into from Nov 26, 2019

Conversation

@balloob
Copy link
Member

balloob commented Nov 22, 2019

Description:

Make conversation integration and intent helpers context aware.

Also moved around and renamed some internal code in the conversation integration so it makes more sense.

Changes the conversation agent signature by adding the context parameter.

CC @synesthesiam

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 22, 2019

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (conversation) you are listed as a codeowner for? Thanks!

@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 22, 2019

Hey there @gcampax, mind taking a look at this pull request as its been labeled with a integration (almond) you are listed as a codeowner for? Thanks!

@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 22, 2019

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (http) you are listed as a codeowner for? Thanks!

@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Nov 22, 2019
@pvizeli pvizeli closed this Nov 25, 2019
Dev automation moved this from By Code Owner to Cancelled Nov 25, 2019
@pvizeli pvizeli reopened this Nov 25, 2019
Dev automation moved this from Cancelled to Incoming Nov 25, 2019
WIP
@pvizeli pvizeli force-pushed the intent-context branch from 022ea26 to be349eb Nov 25, 2019
@pvizeli

This comment has been minimized.

Copy link
Member

pvizeli commented Nov 25, 2019

I rebase it to fix the pylint issue

@pvizeli pvizeli merged commit c76f768 into dev Nov 26, 2019
11 checks passed
11 checks passed
CI #20191126.21 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.47%)
Details
codecov/project 94.49% (target 90%)
Details
Dev automation moved this from Incoming to Done Nov 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the intent-context branch Nov 26, 2019
@lock lock bot locked and limited conversation to collaborators Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.