Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Abode sensor temperature reporting #28973

Merged
merged 1 commit into from Nov 23, 2019
Merged

Conversation

@shred86
Copy link
Contributor

shred86 commented Nov 23, 2019

Description:

Fixes an issue where Abode temp/humidity/lux sensors are not reporting a temperature value. Also includes the use of constants where applicable. Request this to be added to the 102.2 milestone.

Related issue (if applicable): fixes #28931

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
@project-bot project-bot bot added this to Needs review in Dev Nov 23, 2019
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Nov 23, 2019
Dev automation moved this from By Code Owner to Reviewer approved Nov 23, 2019
@pvizeli pvizeli added this to the 0.102.2 milestone Nov 23, 2019
@pvizeli pvizeli merged commit 0a58853 into home-assistant:dev Nov 23, 2019
12 checks passed
12 checks passed
CI #20191123.6 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 829e0a7...8f63041
Details
codecov/project 94.47% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Nov 23, 2019
AndreBremer added a commit to AndreBremer/home-assistant that referenced this pull request Nov 24, 2019
@lock lock bot locked and limited conversation to collaborators Nov 24, 2019
@shred86 shred86 deleted the shred86:abode_fix branch Jan 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.