Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code maintenance for HomematicIP Cloud #28980

Merged
merged 2 commits into from Nov 25, 2019
Merged

Conversation

@SukramJ
Copy link
Contributor

SukramJ commented Nov 23, 2019

Description:

  • add more type hints
  • Rename device to entity in async_setup_entry

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
@project-bot project-bot bot added this to Needs review in Dev Nov 23, 2019
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Nov 23, 2019
Dev automation moved this from By Code Owner to Reviewer approved Nov 25, 2019
@pvizeli pvizeli merged commit 1043712 into home-assistant:dev Nov 25, 2019
12 checks passed
12 checks passed
CI #20191123.22 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.47%)
Details
codecov/project 94.47% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Nov 25, 2019
@SukramJ SukramJ deleted the SukramJ:HmIP-type-hints branch Nov 25, 2019
@lock lock bot locked and limited conversation to collaborators Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.