Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid Dovado configuration #28985



Copy link

springstan commented Nov 23, 2019

Breaking Change:


  • Fixed CONFIG_SCHEMA to include DOMAIN
  • fixed getting the data from the configuration.yaml file


DOMAIN = "ecovacs"
CONF_COUNTRY = "country"
CONF_CONTINENT = "continent"
CONFIG_SCHEMA = vol.Schema(
DOMAIN: vol.Schema(
vol.Required(CONF_USERNAME): cv.string,
vol.Required(CONF_PASSWORD): cv.string,
vol.Required(CONF_COUNTRY): vol.All(vol.Lower, cv.string),
vol.Required(CONF_CONTINENT): vol.All(vol.Lower, cv.string),

Related issue (if applicable): fixes #28882

Pull request with documentation for (if applicable): home-assistant/< PR number goes here>

Example entry for configuration.yaml (if applicable):

  host: !secret dovado_ip
  port: !secret dovado_port
  username: !secret dovado_user
  password: !secret dovado_password


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@fabaff fabaff changed the title Dovado Integration: Fixed invalid configuration Fixed invalid Dovado configuration Nov 23, 2019
@springstan springstan changed the title Fixed invalid Dovado configuration Fix invalid Dovado configuration Nov 23, 2019
@balloob balloob merged commit 5f4fc27 into home-assistant:dev Nov 26, 2019
12 checks passed
12 checks passed
CI #20191123.32 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 2c00a9e...8e0f726
codecov/project 94.47% (target 90%)
docs-missing Documentation ok.
@lock lock bot locked and limited conversation to collaborators Nov 27, 2019
@springstan springstan deleted the springstan:fix-dovado-integration-configuration branch Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
3 participants
You can’t perform that action at this time.