Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade zeroconf to 0.24.0 #28986

Merged
merged 1 commit into from Nov 23, 2019
Merged

Upgrade zeroconf to 0.24.0 #28986

merged 1 commit into from Nov 23, 2019

Conversation

@fabaff
Copy link
Member

fabaff commented Nov 23, 2019

Description:

Changelog: https://github.com/jstasiak/python-zeroconf/#0240

Example entry for configuration.yaml (if applicable):

default_config:
$ avahi-browse -alr
+ wlp4s0 IPv4 Home1                                         _home-assistant._tcp local
+ wlp4s0 IPv4 Home                                          _home-assistant._tcp local
+     lo IPv4 Home1                                         _home-assistant._tcp local
= wlp4s0 IPv4 Home1                                         _home-assistant._tcp local
   hostname = [Home1._home-assistant._tcp.local]
   address = [192.168.0.22]
   port = [8123]
   txt = ["requires_api_password=true" "base_url=http://192.168.0.193:8123" "version=0.102.0.dev0"]
=     lo IPv4 Home1                                         _home-assistant._tcp local
   hostname = [localhost]
   address = [192.168.0.22]
   port = [8123]
   txt = ["requires_api_password=true" "base_url=http://192.168.0.22:8123" "version=0.102.0.dev0"]
[...]

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 23, 2019

Hey there @robbiet480, @Kane610, mind taking a look at this pull request as its been labeled with a integration (zeroconf) you are listed as a codeowner for? Thanks!

@cgtobi
cgtobi approved these changes Nov 23, 2019
Copy link
Collaborator

cgtobi left a comment

LGTM

@cgtobi cgtobi merged commit 98eae30 into dev Nov 23, 2019
12 checks passed
12 checks passed
CI #20191123.33 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 2c00a9e...081e08f
Details
codecov/project 94.47% (target 90%)
Details
docs-missing Documentation ok.
@delete-merged-branch delete-merged-branch bot deleted the upgrade-zeroconf branch Nov 23, 2019
AndreBremer added a commit to AndreBremer/home-assistant that referenced this pull request Nov 24, 2019
@lock lock bot locked and limited conversation to collaborators Nov 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.