Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add climate hvac_action for ESPHome #28993

Merged
merged 2 commits into from Nov 25, 2019

Conversation

@OttoWinter
Copy link
Member

OttoWinter commented Nov 23, 2019

Description:

ESPHome has supported hvac_action (called action in esphome) for some time now. But apparently that field never got added to HA's esphome integration.

This PR adds the hvac_action field to the ESPHome climate entity class. Also aioesphomeapi is bumped to add newer climate action field values (drying, fan).

Also ran isort on the file.

Ref esphome/esphome#859

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
OttoWinter added 2 commits Nov 23, 2019
@pvizeli pvizeli merged commit b927f40 into home-assistant:dev Nov 25, 2019
12 checks passed
12 checks passed
CI #20191123.43 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 2a8e99d...577104d
Details
codecov/project 94.47% (target 90%)
Details
docs-missing Documentation ok.
@lock lock bot locked and limited conversation to collaborators Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.