Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move fibaro imports at top-level #28995

Merged
merged 1 commit into from Nov 25, 2019
Merged

Conversation

@Quentame
Copy link
Contributor

Quentame commented Nov 23, 2019

Breaking Change:

None

Description:

Related issue: partially fix #27284 + isort

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
@Quentame Quentame force-pushed the Quentame:fibaro/move-imports branch from 12e675e to 87ee4b3 Nov 23, 2019
@Quentame Quentame changed the title Move fibaro imports at top-level WIP: Move fibaro imports at top-level Nov 23, 2019
@Quentame Quentame force-pushed the Quentame:fibaro/move-imports branch from 87ee4b3 to 2396109 Nov 24, 2019
@Quentame Quentame changed the title WIP: Move fibaro imports at top-level Move fibaro imports at top-level Nov 24, 2019
@pvizeli pvizeli merged commit 5edc45e into home-assistant:dev Nov 25, 2019
11 checks passed
11 checks passed
CI #20191124.31 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 94f8e63...2396109
Details
codecov/project 94.47% (target 90%)
Details
@Quentame Quentame deleted the Quentame:fibaro/move-imports branch Nov 25, 2019
@lock lock bot locked and limited conversation to collaborators Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.