Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new properties and services for V3 SimpliSafe systems #28997

Merged
merged 9 commits into from Nov 26, 2019

Conversation

@bachya
Copy link
Contributor

bachya commented Nov 23, 2019

Description:

Based on user request, this PR adds several new attributes to V3 alarm_control_panel entities:

  • alarm_duration: the number of seconds the alarm will sound when triggered
  • alarm_volume: the current volume of the siren (off, low, medium, and high)
  • chime_volume: the current volume of the door chime (off, low, medium, and high)
  • entry_delay_away: the delay duration (in seconds) when returning to a house in "away" mode
  • entry_delay_home: the delay duration (in seconds) when returning to a house in "home" mode
  • exit_delay_away: the delay duration (in seconds) when leaving a house in "away" mode
  • exit_delay_home: the delay duration (in seconds) when leaving a house in "home" mode
  • light: the current status of the base station light (True for on, False for off)
  • voice_prompt_volume: the current volume of the voice prompt (off, low, medium, and high)

Additionally, the PR adds service calls so that these properties can be modified on the fly.

Related issue (if applicable): N/A

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11281

Example entry for configuration.yaml (if applicable):

simplisafe:
  accounts:
    - username: !secret ss_username
      password: !secret ss_password

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
bachya added 6 commits Nov 23, 2019
@bachya bachya force-pushed the bachya:simplisafe-services branch from 78e3bf9 to e7c3096 Nov 25, 2019
@bachya bachya mentioned this pull request Nov 25, 2019
2 of 2 tasks complete
@MartinHjelmare MartinHjelmare added this to Needs review in Dev Nov 26, 2019
bachya added 2 commits Nov 26, 2019
Dev automation moved this from Needs review to Reviewer approved Nov 26, 2019
@bachya bachya merged commit 2cdd8ad into home-assistant:dev Nov 26, 2019
11 checks passed
11 checks passed
CI #20191126.75 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 647595f...96594c8
Details
codecov/project 94.49% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 26, 2019
@bachya bachya deleted the bachya:simplisafe-services branch Nov 26, 2019
@lock lock bot locked and limited conversation to collaborators Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.