Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade discord.py to 1.2.5 #28998

Merged
merged 1 commit into from Nov 25, 2019
Merged

Upgrade discord.py to 1.2.5 #28998

merged 1 commit into from Nov 25, 2019

Conversation

@fabaff
Copy link
Member

fabaff commented Nov 23, 2019

Description:

Commit log: https://github.com/Rapptz/discord.py/commits/master

Example entry for configuration.yaml (if applicable):

notify:
  - name: discord
    platform: discord
    token: !secret discord

Message sent with "Call Service"

{
  "message": "A message from Home Assistant",
  "target": [
    "3342155142337212455"
    ]
}

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

If the code communicates with devices, web services, or third-party tools:

  • [The manifest file][manifest-docs] has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
@fabaff fabaff force-pushed the upgrade-discord.py branch from b4538c3 to c4ccb9b Nov 24, 2019
@cgtobi
cgtobi approved these changes Nov 25, 2019
Copy link
Collaborator

cgtobi left a comment

LGTM

@cgtobi cgtobi merged commit 5b64052 into dev Nov 25, 2019
11 checks passed
11 checks passed
CI #20191124.41 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing ce8e0e5...c4ccb9b
Details
codecov/project 94.47% (target 90%)
Details
@delete-merged-branch delete-merged-branch bot deleted the upgrade-discord.py branch Nov 25, 2019
@lock lock bot locked and limited conversation to collaborators Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.