Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list of supported countries for Workday Sensor #29000

Merged

Conversation

@springstan
Copy link
Member

springstan commented Nov 23, 2019

Breaking Change:

Description:

Related issue (if applicable): fixes #28977

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

binary_sensor:
  - platform: workday
    country: EE

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@frenck
frenck approved these changes Nov 23, 2019
Copy link
Member

frenck left a comment

Thanks, @springstan! 👍

@springstan

This comment has been minimized.

Copy link
Member Author

springstan commented Nov 23, 2019

Of course, @frenck! ✌

@springstan

This comment has been minimized.

Copy link
Member Author

springstan commented Nov 23, 2019

Error on FullCheck Pylint seems to be unrelated to this PR. I am pretty sure a rerun fixes that error :)

@fabaff

This comment has been minimized.

Copy link
Member

fabaff commented Nov 23, 2019

This PR (dr-prodigy/python-holidays#247) would allow us to get the supported countries from the module itself and we wouldn't have to maintain the country list anymore.

@springstan

This comment has been minimized.

Copy link
Member Author

springstan commented Nov 24, 2019

The PR you linked looks really good 👍 So should I close this PR or is it more beneficial to update this list manually until your mentioned PR gets merged?

@springstan springstan requested a review from fabaff Nov 24, 2019
@fabaff

This comment has been minimized.

Copy link
Member

fabaff commented Nov 24, 2019

The PR you linked looks really good +1 So should I close this PR or is it more beneficial to update this list manually until your mentioned PR gets merged?

We should merge this PR because we don't know how long it takes till dr-prodigy/python-holidays#247 is introduced and available/released.

@MartinHjelmare MartinHjelmare added this to Review in progress in Dev Nov 26, 2019
@springstan springstan closed this Nov 26, 2019
Dev automation moved this from Review in progress to Cancelled Nov 26, 2019
@springstan springstan reopened this Nov 26, 2019
Dev automation moved this from Cancelled to Incoming Nov 26, 2019
@springstan

This comment has been minimized.

Copy link
Member Author

springstan commented Nov 26, 2019

Reopened to rerun the checks

@fabaff
fabaff approved these changes Nov 26, 2019
Dev automation moved this from Incoming to Reviewer approved Nov 26, 2019
@fabaff fabaff merged commit b72c6c4 into home-assistant:dev Nov 26, 2019
11 checks passed
11 checks passed
CI #20191126.72 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 6ad74fb...25bc55f
Details
codecov/project 94.72% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 26, 2019
@lock lock bot locked and limited conversation to collaborators Nov 27, 2019
@springstan springstan deleted the springstan:update-country-list-workday-sensor branch Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.