Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move yi imports at top-level #29001

merged 3 commits into from Nov 25, 2019

Move yi imports at top-level #29001

merged 3 commits into from Nov 25, 2019


Copy link

Quentame commented Nov 23, 2019

Breaking Change:



Related issue: partially f!x #27284 + isort


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 23, 2019

Hey there @bachya, mind taking a look at this pull request as its been labeled with a integration (yi) you are listed as a codeowner for? Thanks!

@Quentame Quentame force-pushed the Quentame:yi/move-imports branch from c8ed52d to 80f8826 Nov 24, 2019
homeassistant/components/yi/ Outdated Show resolved Hide resolved
@Quentame Quentame force-pushed the Quentame:yi/move-imports branch from 80f8826 to 40e55c1 Nov 25, 2019
@Quentame Quentame force-pushed the Quentame:yi/move-imports branch from 40e55c1 to d2fbf2e Nov 25, 2019
bachya approved these changes Nov 25, 2019
@bachya bachya merged commit c4108fe into home-assistant:dev Nov 25, 2019
11 checks passed
11 checks passed
CI #20191125.101 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 3dd5222...d2fbf2e
codecov/project 94.48% (target 90%)
@Quentame Quentame deleted the Quentame:yi/move-imports branch Nov 25, 2019
@lock lock bot locked and limited conversation to collaborators Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
3 participants
You can’t perform that action at this time.