Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle offline state of SAJ inverters (fixes #29007) #29009

Merged
merged 2 commits into from Nov 25, 2019

Conversation

@fredericvl
Copy link
Contributor

fredericvl commented Nov 24, 2019

Description:

When inverter is offline, for example due to darkness, and HA is restarted at that moment the sensors are not available and do not come available automatically when the inverter is back online at day.
In this case a restart of HA is needed to get it working again.
The fix implements the PlatformNotReady exception to retry until the inverter is online at daylight.

Related issue (if applicable): fixes #29007

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
@fabaff
fabaff approved these changes Nov 24, 2019
Copy link
Member

fabaff left a comment

Looks good to me.

@fabaff fabaff changed the title Fix for SAJ issue #29007 Handle offline state of SAJ inverters (fixes #29007) Nov 24, 2019
@cgarwood cgarwood merged commit 3e4f7fd into home-assistant:dev Nov 25, 2019
11 checks passed
11 checks passed
CI #20191124.50 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing bbca6e3...db5845d
Details
codecov/project 94.47% (target 90%)
Details
@lock lock bot locked and limited conversation to collaborators Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.