Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure wheel package is present when running Pylint #29012

Merged
merged 1 commit into from Nov 24, 2019
Merged

Ensure wheel package is present when running Pylint #29012

merged 1 commit into from Nov 24, 2019

Conversation

@frenck
Copy link
Member

frenck commented Nov 24, 2019

Description:

Attempt to fix our builds, somehow, it seems like the wheel package is gone missing? Not sure where it changed or why this happens now.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
@cgtobi
cgtobi approved these changes Nov 24, 2019
Copy link
Collaborator

cgtobi left a comment

LGTM

@frenck frenck merged commit 94f8e63 into dev Nov 24, 2019
12 checks passed
12 checks passed
CI #20191124.10 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing bbca6e3...338f53b
Details
codecov/project 94.47% (target 90%)
Details
docs-missing Documentation ok.
@delete-merged-branch delete-merged-branch bot deleted the frenck-2019-0273 branch Nov 24, 2019
@springstan springstan mentioned this pull request Nov 24, 2019
5 of 5 tasks complete
@bachya bachya mentioned this pull request Nov 25, 2019
3 of 9 tasks complete
@lock lock bot locked and limited conversation to collaborators Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.