Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Use TADO_MODE for temperature overrides in tado climate component. #29014
Temperature overrides are now cancelled when the schedule dictates that the temperature should be lowered (or raised, depending on your climate), like during the night. The current behavior caused my house to be heated during the night a few times since I forgot to set set the mode back to auto, after changing the temperature during a cold evening. This restores the behavior like it was before the big Climate 1.0 PR from Home Assistant 0.95 and makes it consistent with the Tado device and Tado App.
Since the "Climate 1.0 PR", when you make a temperature override, the operation mode is switched to "Manual", making the smart schedules that you could create in the app useless, since they will never apply anymore until you manually switch back to auto. The default behaviour of the Tado Mobile app and the Tado device is to use "Tado Mode", meaning that the override is only valid until the next schedule change.
This has been reported here https://community.home-assistant.io/t/setup-failed-for-tado/105570/175 and here #25714
Related issue (if applicable): fixes #25714
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
If the code does not interact with devices:
I agree in principal with the change, and have this patched in my local custom component because I did not want temp/mode changes to apply perpetually, only until the next schedule change.
I was planning to open a PR to fetch the desired overlay mode from the tado APIs though, rather than just assuming one way or the other though just hadn't gotten around to it yet. That way, the user's preference -- apply forever, until next change, or timer -- as specified in tado, would apply to any changes made in home assistant too. (Possibly needs a change in the tado library to get this info, I forget)
I've also looked at using the stored preference at tado, but this requires the py-tado library to fetch the