Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move imports to top for todoist #29022

merged 1 commit into from Nov 25, 2019


Copy link

springstan commented Nov 24, 2019

Breaking Change:


  • moved all imports to the top

Related issue (if applicable): #27284

Pull request with documentation for (if applicable): home-assistant/< PR number goes here>

Example entry for configuration.yaml (if applicable):


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 24, 2019

Hey there @boralyl, mind taking a look at this pull request as its been labeled with a integration (todoist) you are listed as a codeowner for? Thanks!

Copy link

boralyl left a comment

This looks good to me. I've seen another repo also move the imports. I didn't realize that we didn't need to keep imports installed via the manifest.json inside our classes anymore. Are there any docs or discussions about this change, I'd love to stay up to date.

EDIT: Whoops, didn't see the linked issue. This is great!

cgtobi approved these changes Nov 25, 2019
@cgtobi cgtobi merged commit ee03899 into home-assistant:dev Nov 25, 2019
12 checks passed
12 checks passed
CI #20191124.32 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 94f8e63...695abae
codecov/project 94.47% (target 90%)
docs-missing Documentation ok.
@lock lock bot locked and limited conversation to collaborators Nov 26, 2019
@springstan springstan deleted the springstan:move-imports-todoist branch Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
4 participants
You can’t perform that action at this time.